-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/macos all runtimes #1823
Merged
RobertSamoilescu
merged 23 commits into
SeldonIO:master
from
RobertSamoilescu:fix/macos-all-runtimes
Jun 19, 2024
Merged
Fix/macos all runtimes #1823
RobertSamoilescu
merged 23 commits into
SeldonIO:master
from
RobertSamoilescu:fix/macos-all-runtimes
Jun 19, 2024
+25
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
7 times, most recently
from
June 18, 2024 10:34
4d5a18d
to
d88f5ff
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 18, 2024 10:38
d88f5ff
to
36aae4b
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
2 times, most recently
from
June 18, 2024 14:31
6bc5366
to
796b6c6
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 18, 2024 15:28
796b6c6
to
0d84eb2
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 18, 2024 18:03
7f81d6b
to
e942d01
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
3 times, most recently
from
June 18, 2024 20:35
74482c9
to
50d2806
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 18, 2024 20:37
50d2806
to
a87f040
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 19, 2024 07:23
89aea98
to
3733b61
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 19, 2024 07:53
0130a94
to
752611b
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 19, 2024 08:12
3bd8067
to
204211d
Compare
RobertSamoilescu
force-pushed
the
fix/macos-all-runtimes
branch
from
June 19, 2024 08:22
63b1d51
to
91c5823
Compare
sakoush
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Sherif Akoush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
all-runtimes
tests for macos and reduces flakiness for the other tests.Related to #1184
Seems that there is work in progress wrt to this issue on both lightgbm and xgboost. Hopefully, in the near future we can simplify the installation of OpenMP and use the latest version:
lightgbm==4.4.0
)Other relevant links: